lc_classifier: Modified tqdm pbar import #566
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When lc_classifier is extracting features, the current implementation uses the default tqdm module intended for scripts, even if running on an IPy Notebook. tqdm does offer a notebook variant, but, it also offers the ability to infer it automatically through tqdm.auto.
I modified the code to import from
tqdm.auto
instead oftqdm
. This will automatically invoke the right type of progress bar to be used depending on the platform (script v/s notebook).Summary of the changes
Changed
from tqdm import tqdm
tofrom tqdm.auto import tqdm
Observations
This probably adds a very small overhead to the import as tqdm automatically infers the type of platform, namely, it tries in the following order:
tqdm.autonotebook
without import warningstqdm.asyncio
tqdm.std
base classBut, this overhead should still be negligible, and will be helpful for people using it on IPy Notebooks (like me!)
Ref: https://github.com/tqdm/tqdm/blob/master/tqdm/auto.py