3.0.0: Support special case raw binary strings #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonpaulos
commented
Jul 26, 2024
gmalouf
reviewed
Jul 31, 2024
Contributor
gmalouf
left a comment
gmalouf
left a comment
There was a problem hiding this comment.
Overall is looking good, a few comments and questions to go through.
gmalouf
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fields in
EvalDeltaare encoded as msgpack strings, but they actually contain arbitrary binary data. In order to properly decode these values in this SDK, this PR uses raw string decoding made available from our forked https://github.com/algorand/msgpack-javascriptThis PR relies on unreleased changes to the msgpack library, made in this PR: algorand/msgpack-javascript#6. That should be merged and released before this is mergable.
Closes #724