Skip to content

Conversation

@jasonpaulos
Copy link
Contributor

Use the prerelease tag when generating the changelog for release PRs.

If a prerelease version is specified, right now that is not used when generating the release PR with the planned version tag.

For example, that causes this statement to be at the end of the changelog:

Full Changelog: v2.9.0...v3.0.0

Instead of:

Full Changelog: v2.9.0...v3.0.0-beta.1

I manually updated it in #891, but it would be nice to fix this at the source

@jasonpaulos jasonpaulos requested a review from a team as a code owner August 21, 2024 17:23
Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there's some hokeyness when handling beta releases, since they aren't exactly new releases; I suppose new versions of beta will still include previous beta changes. Overall I think this is fine, but may involve manual work to clean up follow up beta releases.

@jasonpaulos jasonpaulos merged commit d2ea927 into develop Aug 26, 2024
@jasonpaulos jasonpaulos deleted the prerelease-tag-changelog-fix branch August 26, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants