-
Notifications
You must be signed in to change notification settings - Fork 120
[ARC-90] Consolidation of URI schemes + network handling #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@SudoWeezy I think consolidating all URI-related ARCs is a good move to avoid fragmentation. I would suggest the following improvements:
|
|
I added the following: Algorand URIs that need to declare conformance with multiple ARC MUST encode that declaration in the URI fragment using the pattern |
| ; Network authority selectors | ||
| netauth = ghlabel / netlabel | ||
| ghlabel = "gh:" 1*qbase64url | ||
| netlabel = "net:" ( "testnet" / "betanet" / alabel ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use official genesis name like mainnet-v1.0 please? or if testnet is the algorand testnet-v1.0 can someone create mapping for known netlables to genesis ids?
| amountparam = "amount=" *digit | ||
| labelparam = "label=" *qchar | ||
| assetparam = "asset=" *digit | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ARC26 is missing the sender definition.. can we add one of the params to be sender please? The sender is important for QR code receivers - wallets so that they do not have to setup special UX to select account when they want to process the transaction. much better is if frontend is already connected to the wallet and knows who is the sender just to pass it in parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can consider adding a from parameter to ARC-90 as an optional, advisory field.
Something like:
fromparam = "from=" algorandaddress
from: Optional sender account address.
Wallets MAY use this to pre-select the account initiating the transaction,
but MUST verify that the provided address belongs to the user before constructing or signing any transaction.
If the address is not recognized or available, wallets MUST ignore this parameter.
It still needs to be talked about before it's included.
Summary