Skip to content

Fix infinite watcher recursion #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix infinite watcher recursion #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/angular-plotly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
subscribeToEvents(graph);
}
}
graph.layout = scope.plotlyLayout;
// Copy the layout so that internal updates by plotly don't trigger the watcher, otherwise
// we can end up in infinite watcher recursion -- this can happen when plotting time series data
graph.layout = angular.copy(scope.plotlyLayout);
graph.data = scope.plotlyData;
Plotly.redraw(graph);
Plotly.Plots.resize(graph);
Expand Down