-
Notifications
You must be signed in to change notification settings - Fork 7
Enable prefix caching on vllm 0.6.2 #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
29b3cbb to
10ad43c
Compare
gc-fu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides these two comments, others LGTM
| if computed_block_nums is not None: | ||
| context_len = len(computed_block_nums) * self.block_size | ||
| else: | ||
| context_len = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider chunked prefill, this should probably be seq_data.get_num_computed_tokens()?
vllm/worker/xpu_model_runner.py
Outdated
| # Last token | ||
| tokens = [seq_data.get_last_token_id()] | ||
|
|
||
| # FIXME: add prefix caching |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this FIXME?
|
Also for multi-modal input, I am not very sure... |
Refer to #48.
Enable multimodal too.
Need to compare performance.