Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,25 @@ protected TaskWriter<Record> dataWriter() {
@Override
protected long targetSize() {
long targetSize = super.targetSize();
long inputSize =
Arrays.stream(input.rewrittenDataFiles()).mapToLong(DataFile::fileSizeInBytes).sum();
// When the input files’ total size is below targetSize, remove the output file size limit to
DataFile[] rewrittenDataFiles = input.rewrittenDataFiles();
if (rewrittenDataFiles == null || rewrittenDataFiles.length == 0) {
return targetSize;
}
long inputSize = Arrays.stream(rewrittenDataFiles).mapToLong(DataFile::fileSizeInBytes).sum();
// When the input files' total size is below targetSize, remove the output file size limit to
// avoid outputting multiple files.
// For more details, please refer to: https://github.com/apache/amoro/issues/3645
return inputSize < targetSize ? Long.MAX_VALUE : targetSize;
if (inputSize < targetSize) {
return Long.MAX_VALUE;
}
// Even if total size >= targetSize, if average file size is small (less than targetSize),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this output a single file with too big file size?

// we should still merge files to avoid outputting too many small files.
// This ensures that many small files can be merged effectively.
long averageFileSize = inputSize / rewrittenDataFiles.length;
if (averageFileSize < targetSize) {
return Long.MAX_VALUE;
}
return targetSize;
}

private PartitionSpec fileSpec() {
Expand Down