Skip to content

Conversation

@liaoyt
Copy link
Contributor

@liaoyt liaoyt commented Nov 4, 2025

Why are the changes needed?

Close #3885.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added the module:ams-server Ams server module label Nov 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.12%. Comparing base (17b68d0) to head (8a59f85).
⚠️ Report is 10 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (17b68d0) and HEAD (8a59f85). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (17b68d0) HEAD (8a59f85)
core 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3886      +/-   ##
============================================
- Coverage     28.82%   22.12%   -6.70%     
+ Complexity     3838     2461    -1377     
============================================
  Files           625      445     -180     
  Lines         50514    40896    -9618     
  Branches       6455     5767     -688     
============================================
- Hits          14560     9050    -5510     
+ Misses        34928    31088    -3840     
+ Partials       1026      758     -268     
Flag Coverage Δ
core ?
trino 22.12% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
I left a comment, PTAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Lost oss.endpoint for internal catalog with mixed_iceberg format

3 participants