Fix auto-completion logic for APIs that end with 'y' #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build complete for PR #194. 🔗 Download the cmk binaries (expires on September 12, 2025) |
shwstppr
reviewed
Sep 3, 2025
Comment on lines
+224
to
+230
| config.Debug("relatedNoun before suffix check: ", relatedNoun) | ||
| if strings.HasSuffix(relatedNoun, "y") && len(relatedNoun) > 1 && !strings.ContainsAny(string(relatedNoun[len(relatedNoun)-2]), "aeiou") { | ||
| // Handle words ending in consonant + y (e.g., policy -> policies) | ||
| relatedNoun = relatedNoun[:len(relatedNoun)-1] + "ies" | ||
| } else if !strings.HasSuffix(relatedNoun, "ies") { | ||
| relatedNoun += "s" | ||
| } |
There was a problem hiding this comment.
@Pearl1594 can we make this a separate method. I gues we are trying to do something similar around line 258 as well for autocompleting for name param. Maybe we can reuse?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, autocompletion works for APIs ending in 'y' or 'ies' e.g. deleteSnapshotPolicies , deleteAutoscalePolicy