Add note advising to not cache Set-Cookie when cookie is used for session identification #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! We got bit pretty hard by this issue recently and I thought it would be prudent to add a warning to the documentation.
If the
Set-Cookieheader is being used to identify users, it is crucial that the header not be cached bymod_cache. If we do cache the cookie, the user identifying cookie (potentially containing unencrypted login credentials) may be given to another user, causing an unintentional session hijacking.French translations created via Google translate, not verified.
Sources:
https://www.apachelounge.com/viewtopic.php?p=43026
https://www.softslate.com/blog/2011/07/apache-modcache-in-real-world.html (See: Bitten by the Cookie)
https://confluence.atlassian.com/jirakb/request-assumes-identity-of-another-user-who-logs-in-concurrently-due-to-apache-cacheignoreheaders-226791609.html)