Skip to content

mod_log_config: better handle invalid log file name #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

mod_log_config: better handle invalid log file name #504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions modules/loggers/mod_log_config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1916,11 +1916,21 @@ static int check_log_dir(apr_pool_t *p, server_rec *s, config_log_state *cls)
return OK;
}
else {
char *abs = ap_server_root_relative(p, cls->fname);
char *dir = ap_make_dirstr_parent(p, abs);
char *dir;
apr_finfo_t finfo;
apr_status_t rv;
const ap_directive_t *directive = cls->directive;
apr_status_t rv = apr_stat(&finfo, dir, APR_FINFO_TYPE, p);
char *abs = ap_server_root_relative(p, cls->fname);
if (!abs) {
ap_log_error(APLOG_MARK, APLOG_STARTUP|APLOG_EMERG, 0, s,
APLOGNO()
"Cannot construct log file path '%s' "
"defined at %s:%d", cls->fname,
directive->filename, directive->line_num);
return !OK;
}
dir = ap_make_dirstr_parent(p, abs);
rv = apr_stat(&finfo, dir, APR_FINFO_TYPE, p);
cls->directive = NULL; /* Don't check this config_log_state again */
if (rv == APR_SUCCESS && finfo.filetype != APR_DIR)
rv = APR_ENOTDIR;
Expand Down
Loading