-
Notifications
You must be signed in to change notification settings - Fork 139
Target Platform Support #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Target Platform Support #1614
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2208dca
Platform WIP
cstamas a781b7f
WIP
cstamas 66f73f9
Drop unused for now
cstamas 5d22788
Guard better for nulls
cstamas 2ddd3db
Javadoc
cstamas 9b62d43
Drop this method
cstamas 8e917e6
Drop this
cstamas 8e740eb
Target Plarform support
cstamas 007024a
WIP
cstamas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
maven-resolver-api/src/main/java/org/eclipse/aether/collection/DependencyManagementKey.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,75 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package org.eclipse.aether.collection; | ||
|
||
import java.util.Objects; | ||
|
||
import org.eclipse.aether.artifact.Artifact; | ||
|
||
/** | ||
* A key used for dependency management. | ||
* | ||
* @since 2.0.13 | ||
*/ | ||
public final class DependencyManagementKey { | ||
private final String groupId; | ||
private final String artifactId; | ||
private final String extension; | ||
private final String classifier; | ||
private final int hashCode; | ||
|
||
/** | ||
* Creates a new DM key for given artifact. | ||
*/ | ||
public DependencyManagementKey(Artifact artifact) { | ||
this.groupId = artifact.getGroupId(); | ||
this.artifactId = artifact.getArtifactId(); | ||
this.extension = artifact.getExtension(); | ||
this.classifier = artifact.getClassifier(); | ||
this.hashCode = Objects.hash(groupId, artifactId, extension, classifier); | ||
} | ||
|
||
@Override | ||
public boolean equals(Object obj) { | ||
if (obj == this) { | ||
return true; | ||
} else if (!(obj instanceof DependencyManagementKey)) { | ||
return false; | ||
} | ||
DependencyManagementKey that = (DependencyManagementKey) obj; | ||
return artifactId.equals(that.artifactId) | ||
&& groupId.equals(that.groupId) | ||
&& extension.equals(that.extension) | ||
&& classifier.equals(that.classifier); | ||
} | ||
|
||
@Override | ||
public int hashCode() { | ||
return hashCode; | ||
} | ||
|
||
@Override | ||
public String toString() { | ||
if (classifier.isEmpty()) { | ||
return groupId + ":" + artifactId + ":" + extension; | ||
} else { | ||
return groupId + ":" + artifactId + ":" + extension + ":" + classifier; | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We many times missing description on deprecations .... why, what should be used instead of ... and so on