Skip to content

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Aug 21, 2025

Having:

@Ann(1)

and removing the 1, currently the outcome is:

@Ann()

It would be better to produce @Ann, without the (), which is what this PR is trying to do.


^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

  • are all your own work, and you have the right to contribute them.
  • are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

  1. Was this PR correctly labeled, did the right tests run? When did they run?
  2. Is this PR squashed?
  3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
  4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

@lahodaj lahodaj added this to the NB28 milestone Aug 21, 2025
@lahodaj lahodaj added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Aug 21, 2025
@mbien
Copy link
Member

mbien commented Aug 21, 2025

just to clarify: with removing you mean as refactoring/AST operation, not actually in-editor typing, right?

@lahodaj
Copy link
Contributor Author

lahodaj commented Aug 22, 2025

Correct, when the AST is being transformed. I'll fix the tests later.

FWIW, the overall context here is:
https://github.com/lahodaj/netbeans/tree/openjdk-testng-junit-fixes-and-hacks/java/java.openjdk.project/junit-convert

Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Comment on lines +1141 to +1142
"package hierbas.del.litoral;\n" +
"\n" +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

want to use code blocks for new tests?

@mbien
Copy link
Member

mbien commented Sep 16, 2025

@lahodaj outside of squash and rebase, this could be merged since it looks ready, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Need Squashing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants