Skip to content

Add support for GlassFish 7.0.25, and GlassFish 8.0.0-M12 #8779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for GlassFish 7.0.25, and GlassFish 8.0.0-M12 #8779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/Bundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ STR_7021_SERVER_NAME=GlassFish Server 7.0.21
STR_7022_SERVER_NAME=GlassFish Server 7.0.22
STR_7023_SERVER_NAME=GlassFish Server 7.0.23
STR_7024_SERVER_NAME=GlassFish Server 7.0.24
STR_7025_SERVER_NAME=GlassFish Server 7.0.25
STR_800_SERVER_NAME=GlassFish Server 8.0.0

# CommonServerSupport.java
Expand Down
15 changes: 13 additions & 2 deletions enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ServerDetails.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,15 +555,26 @@ public enum ServerDetails {
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/7.0.24/glassfish-7.0.24.zip", // NOI18N
"http://www.eclipse.org/legal/epl-2.0" //NOI18N
),

/**
* details for an instance of GlassFish Server 7.0.24
*/
GLASSFISH_SERVER_7_0_25(NbBundle.getMessage(ServerDetails.class, "STR_7025_SERVER_NAME", new Object[]{}), // NOI18N
GlassfishInstanceProvider.JAKARTAEE10_DEPLOYER_FRAGMENT,
GlassFishVersion.GF_7_0_25,
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/7.0.25/glassfish-7.0.25.zip", // NOI18N
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/7.0.25/glassfish-7.0.25.zip", // NOI18N
"http://www.eclipse.org/legal/epl-2.0" //NOI18N
),

/**
* details for an instance of GlassFish Server 8.0.0
*/
GLASSFISH_SERVER_8_0_0(NbBundle.getMessage(ServerDetails.class, "STR_800_SERVER_NAME", new Object[]{}), // NOI18N
GlassfishInstanceProvider.JAKARTAEE11_DEPLOYER_FRAGMENT,
GlassFishVersion.GF_8_0_0,
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M11/glassfish-8.0.0-M11.zip", // NOI18N
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M11/glassfish-8.0.0-M11.zip", // NOI18N
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M12.zip", // NOI18N
"https://repo.maven.apache.org/maven2/org/glassfish/main/distributions/glassfish/8.0.0-M12/glassfish-8.0.0-M12.zip", // NOI18N
"http://www.eclipse.org/legal/epl-2.0" //NOI18N
);

Expand Down
1 change: 1 addition & 0 deletions ...rise/glassfish.common/src/org/netbeans/modules/glassfish/common/wizards/Bundle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ STR_7021_SERVER_NAME=GlassFish Server 7.0.21
STR_7022_SERVER_NAME=GlassFish Server 7.0.22
STR_7023_SERVER_NAME=GlassFish Server 7.0.23
STR_7024_SERVER_NAME=GlassFish Server 7.0.24
STR_7025_SERVER_NAME=GlassFish Server 7.0.25

STR_V8_FAMILY_NAME=GlassFish Server
STR_800_SERVER_NAME=GlassFish Server 8.0.0
Expand Down
8 changes: 8 additions & 0 deletions ...e/glassfish.tooling/src/org/netbeans/modules/glassfish/tooling/data/GlassFishVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ public enum GlassFishVersion {
GF_7_0_23 ((short) 7, (short) 0, (short) 23, (short) 0, GlassFishVersion.GF_7_0_23_STR),
/** GlassFish 7.0.24 */
GF_7_0_24 ((short) 7, (short) 0, (short) 24, (short) 0, GlassFishVersion.GF_7_0_24_STR),
/** GlassFish 7.0.25 */
GF_7_0_25 ((short) 7, (short) 0, (short) 25, (short) 0, GlassFishVersion.GF_7_0_25_STR),
/** GlassFish 8.0.0 */
GF_8_0_0 ((short) 8, (short) 0, (short) 0, (short) 0, GlassFishVersion.GF_8_0_0_STR);
// Class attributes //
Expand Down Expand Up @@ -417,6 +419,11 @@ public enum GlassFishVersion {
static final String GF_7_0_24_STR = "7.0.24";
/** Additional {@code String} representations of GF_7_0_24 value. */
static final String GF_7_0_24_STR_NEXT[] = {"7.0.24", "7.0.24.0"};

/** A {@code String} representation of GF_7_0_25 value. */
static final String GF_7_0_25_STR = "7.0.25";
/** Additional {@code String} representations of GF_7_0_25 value. */
static final String GF_7_0_25_STR_NEXT[] = {"7.0.25", "7.0.25.0"};

/** A {@code String} representation of GF_8_0_0 value. */
static final String GF_8_0_0_STR = "8.0.0";
Expand Down Expand Up @@ -484,6 +491,7 @@ public enum GlassFishVersion {
initStringValuesMapFromArray(GF_7_0_22, GF_7_0_22_STR_NEXT);
initStringValuesMapFromArray(GF_7_0_23, GF_7_0_23_STR_NEXT);
initStringValuesMapFromArray(GF_7_0_24, GF_7_0_24_STR_NEXT);
initStringValuesMapFromArray(GF_7_0_25, GF_7_0_25_STR_NEXT);
initStringValuesMapFromArray(GF_8_0_0, GF_8_0_0_STR_NEXT);
}

Expand Down
11 changes: 8 additions & 3 deletions ...oling/src/org/netbeans/modules/glassfish/tooling/server/config/ConfigBuilderProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,11 @@ public class ConfigBuilderProvider {
private static final Config.Next CONFIG_V7_0_24
= new Config.Next(GlassFishVersion.GF_7_0_24,
ConfigBuilderProvider.class.getResource("GlassFishV7_0_24.xml"));

/** Library builder configuration since GlassFish 7.0.25. */
private static final Config.Next CONFIG_V7_0_25
= new Config.Next(GlassFishVersion.GF_7_0_25,
ConfigBuilderProvider.class.getResource("GlassFishV7_0_24.xml"));

/** Library builder configuration since GlassFish 8.0.0. */
private static final Config.Next CONFIG_V8_0_0
Expand All @@ -255,13 +260,13 @@ public class ConfigBuilderProvider {
CONFIG_V7_0_15, CONFIG_V7_0_16, CONFIG_V7_0_17,
CONFIG_V7_0_18, CONFIG_V7_0_19, CONFIG_V7_0_20,
CONFIG_V7_0_21, CONFIG_V7_0_22, CONFIG_V7_0_23,
CONFIG_V7_0_24, CONFIG_V8_0_0);
CONFIG_V7_0_24, CONFIG_V7_0_24, CONFIG_V8_0_0);

/** Builders array for each server instance. */
private static final ConcurrentMap<GlassFishServer, ConfigBuilder> builders
= new ConcurrentHashMap<>(32);
= new ConcurrentHashMap<>(64);

// Static methods //
// Static methods
/**
* Get library builder configuration for given GlassFish server version.
* <p/>
Expand Down
2 changes: 1 addition & 1 deletion ...fish.tooling/src/org/netbeans/modules/glassfish/tooling/server/config/GlassFishV8_0_0.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
</fileset>
</classpath>
<javadocs>
<link url="https://repo.maven.apache.org/maven2/org/glassfish/jersey/jersey-documentation/4.0.0-M2/jersey-documentation-4.0.0-M2-docbook.zip"/>
<link url="https://repo.maven.apache.org/maven2/org/glassfish/jersey/jersey-documentation/4.0.0-M3/jersey-documentation-4.0.0-M3-docbook.zip"/>
</javadocs>
<sources>
</sources>
Expand Down
4 changes: 2 additions & 2 deletions ....tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/admin/AdminFactoryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,15 +165,15 @@ public void testGetInstanceforVersionGF6() {
}

/**
* Test factory functionality for GlassFish v. 7.0.24
* Test factory functionality for GlassFish v. 7.0.25
* <p/>
* Factory should initialize REST {@code Runner} and point it to
* provided {@code Command} instance.
*/
@Test
public void testGetInstanceforVersionGF7() {
GlassFishServerEntity srv = new GlassFishServerEntity();
srv.setVersion(GlassFishVersion.GF_7_0_24);
srv.setVersion(GlassFishVersion.GF_7_0_25);
AdminFactory af = AdminFactory.getInstance(srv.getVersion());
assertTrue(af instanceof AdminFactoryRest);
Command cmd = new CommandVersion();
Expand Down
8 changes: 6 additions & 2 deletions ...oling/test/unit/src/org/netbeans/modules/glassfish/tooling/data/GlassFishVersionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ public void testToValue() {
GlassFishVersion.GF_7_0_23_STR_NEXT);
verifyToValueFromAdditionalArray(GlassFishVersion.GF_7_0_24,
GlassFishVersion.GF_7_0_24_STR_NEXT);
verifyToValueFromAdditionalArray(GlassFishVersion.GF_7_0_25,
GlassFishVersion.GF_7_0_25_STR_NEXT);
verifyToValueFromAdditionalArray(GlassFishVersion.GF_8_0_0,
GlassFishVersion.GF_8_0_0_STR_NEXT);
}
Expand Down Expand Up @@ -176,7 +178,8 @@ public void testToValueIncomplete() {
GlassFishVersion.GF_7_0_18, GlassFishVersion.GF_7_0_19,
GlassFishVersion.GF_7_0_20, GlassFishVersion.GF_7_0_21,
GlassFishVersion.GF_7_0_22, GlassFishVersion.GF_7_0_23,
GlassFishVersion.GF_7_0_24, GlassFishVersion.GF_8_0_0
GlassFishVersion.GF_7_0_24, GlassFishVersion.GF_7_0_25,
GlassFishVersion.GF_8_0_0
};
String strings[] = {
"1.0.1.4", "2.0.1.5", "2.1.0.3", "2.1.1.7",
Expand All @@ -191,7 +194,8 @@ public void testToValueIncomplete() {
"7.0.10.0", "7.0.11.0", "7.0.12.0", "7.0.13.0",
"7.0.14.0", "7.0.15.0", "7.0.16.0", "7.0.17.0",
"7.0.18.0", "7.0.19.0", "7.0.20.0", "7.0.21.0",
"7.0.22.0", "7.0.23.0", "7.0.24.0", "8.0.0.0"
"7.0.22.0", "7.0.23.0", "7.0.24.0", "7.0.25.0",
"8.0.0.0"
};
for (int i = 0; i < versions.length; i++) {
GlassFishVersion version = GlassFishVersion.toValue(strings[i]);
Expand Down
38 changes: 19 additions & 19 deletions ...ish.tooling/test/unit/src/org/netbeans/modules/glassfish/tooling/utils/EnumUtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import static org.netbeans.modules.glassfish.tooling.data.GlassFishVersion.GF_3;
import static org.netbeans.modules.glassfish.tooling.data.GlassFishVersion.GF_4;
import static org.netbeans.modules.glassfish.tooling.data.GlassFishVersion.GF_6_2_5;
import static org.netbeans.modules.glassfish.tooling.data.GlassFishVersion.GF_7_0_24;
import static org.netbeans.modules.glassfish.tooling.data.GlassFishVersion.GF_7_0_25;
import static org.netbeans.modules.glassfish.tooling.data.GlassFishVersion.GF_8_0_0;
import static org.testng.Assert.assertFalse;
import static org.testng.Assert.assertTrue;
Expand All @@ -48,10 +48,10 @@ public class EnumUtilsTest {
*/
@Test
public void testEq() {
assertFalse(EnumUtils.eq(GF_8_0_0, GF_7_0_24), "Equals for a > b shall be false.");
assertFalse(EnumUtils.eq(GF_8_0_0, GF_7_0_25), "Equals for a > b shall be false.");
assertTrue(EnumUtils.eq(GF_8_0_0, GF_8_0_0), "Equals for a == b shall be true.");
assertFalse(EnumUtils.eq(GF_7_0_24, GF_6_2_5), "Equals for a > b shall be false.");
assertTrue(EnumUtils.eq(GF_7_0_24, GF_7_0_24), "Equals for a == b shall be true.");
assertFalse(EnumUtils.eq(GF_7_0_25, GF_6_2_5), "Equals for a > b shall be false.");
assertTrue(EnumUtils.eq(GF_7_0_25, GF_7_0_25), "Equals for a == b shall be true.");
assertFalse(EnumUtils.eq(GF_4, GF_3), "Equals for a > b shall be false.");
assertTrue(EnumUtils.eq(GF_4, GF_4), "Equals for a == b shall be true.");
assertFalse(EnumUtils.eq(GF_3, GF_4), "Equals for a < b shall be false.");
Expand All @@ -72,10 +72,10 @@ public void testEq() {
*/
@Test
public void testNe() {
assertTrue(EnumUtils.ne(GF_8_0_0, GF_7_0_24), "Not equals for a > b shall be true.");
assertTrue(EnumUtils.ne(GF_8_0_0, GF_7_0_25), "Not equals for a > b shall be true.");
assertFalse(EnumUtils.ne(GF_8_0_0, GF_8_0_0), "Not equals for a == b shall be false.");
assertTrue(EnumUtils.ne(GF_7_0_24, GF_6_2_5), "Not equals for a > b shall be true.");
assertFalse(EnumUtils.ne(GF_7_0_24, GF_7_0_24), "Not equals for a == b shall be false.");
assertTrue(EnumUtils.ne(GF_7_0_25, GF_6_2_5), "Not equals for a > b shall be true.");
assertFalse(EnumUtils.ne(GF_7_0_25, GF_7_0_25), "Not equals for a == b shall be false.");
assertTrue(EnumUtils.ne(GF_4, GF_3), "Not equals for a > b shall be true.");
assertFalse(EnumUtils.ne(GF_4, GF_4), "Not equals for a == b shall be false.");
assertTrue(EnumUtils.ne(GF_3, GF_4), "Not equals for a < b shall be true.");
Expand All @@ -96,10 +96,10 @@ public void testNe() {
*/
@Test
public void testLt() {
assertFalse(EnumUtils.lt(GF_8_0_0, GF_7_0_24), "Less than for a > b shall be false.");
assertFalse(EnumUtils.lt(GF_8_0_0, GF_7_0_25), "Less than for a > b shall be false.");
assertFalse(EnumUtils.lt(GF_8_0_0, GF_8_0_0), "Less than for a == b shall be false.");
assertFalse(EnumUtils.lt(GF_7_0_24, GF_6_2_5), "Less than for a > b shall be false.");
assertFalse(EnumUtils.lt(GF_7_0_24, GF_7_0_24), "Less than for a == b shall be false.");
assertFalse(EnumUtils.lt(GF_7_0_25, GF_6_2_5), "Less than for a > b shall be false.");
assertFalse(EnumUtils.lt(GF_7_0_25, GF_7_0_25), "Less than for a == b shall be false.");
assertFalse(EnumUtils.lt(GF_4, GF_3), "Less than for a > b shall be false.");
assertFalse(EnumUtils.lt(GF_4, GF_4), "Less than for a == b shall be false.");
assertTrue(EnumUtils.lt(GF_3, GF_4), "Less than for a < b shall be true.");
Expand All @@ -120,10 +120,10 @@ public void testLt() {
*/
@Test
public void testLe() {
assertFalse(EnumUtils.le(GF_8_0_0, GF_7_0_24), "Less than or equal for a > b shall be false.");
assertFalse(EnumUtils.le(GF_8_0_0, GF_7_0_25), "Less than or equal for a > b shall be false.");
assertTrue(EnumUtils.le(GF_8_0_0, GF_8_0_0), "Less than or equal for a == b shall be true.");
assertFalse(EnumUtils.le(GF_7_0_24, GF_6_2_5), "Less than or equal for a > b shall be false.");
assertTrue(EnumUtils.le(GF_7_0_24, GF_7_0_24), "Less than or equal for a == b shall be true.");
assertFalse(EnumUtils.le(GF_7_0_25, GF_6_2_5), "Less than or equal for a > b shall be false.");
assertTrue(EnumUtils.le(GF_7_0_25, GF_7_0_25), "Less than or equal for a == b shall be true.");
assertFalse(EnumUtils.le(GF_4, GF_3), "Less than or equal for a > b shall be false.");
assertTrue(EnumUtils.le(GF_4, GF_4), "Less than or equal for a == b shall be true.");
assertTrue(EnumUtils.le(GF_3, GF_4), "Less than or equal for a < b shall be true.");
Expand All @@ -144,10 +144,10 @@ public void testLe() {
*/
@Test
public void testGt() {
assertTrue(EnumUtils.gt(GF_8_0_0, GF_7_0_24), "Greater than for a > b shall be true.");
assertTrue(EnumUtils.gt(GF_8_0_0, GF_7_0_25), "Greater than for a > b shall be true.");
assertFalse(EnumUtils.gt(GF_8_0_0, GF_8_0_0), "Greater than for a == b shall be false.");
assertTrue(EnumUtils.gt(GF_7_0_24, GF_6_2_5), "Greater than for a > b shall be true.");
assertFalse(EnumUtils.gt(GF_7_0_24, GF_7_0_24), "Greater than for a == b shall be false.");
assertTrue(EnumUtils.gt(GF_7_0_25, GF_6_2_5), "Greater than for a > b shall be true.");
assertFalse(EnumUtils.gt(GF_7_0_25, GF_7_0_25), "Greater than for a == b shall be false.");
assertTrue(EnumUtils.gt(GF_4, GF_3), "Greater than for a > b shall be true.");
assertFalse(EnumUtils.gt(GF_4, GF_4), "Greater than for a == b shall be false.");
assertFalse(EnumUtils.gt(GF_3, GF_4), "Greater than for a < b shall be false.");
Expand All @@ -168,10 +168,10 @@ public void testGt() {
*/
@Test
public void testGe() {
assertTrue(EnumUtils.ge(GF_8_0_0, GF_7_0_24), "Greater than or equal for a > b shall be true.");
assertTrue(EnumUtils.ge(GF_8_0_0, GF_7_0_25), "Greater than or equal for a > b shall be true.");
assertTrue(EnumUtils.ge(GF_8_0_0, GF_8_0_0), "Greater than or equal for a == b shall be true.");
assertTrue(EnumUtils.ge(GF_7_0_24, GF_6_2_5), "Greater than or equal for a > b shall be true.");
assertTrue(EnumUtils.ge(GF_7_0_24, GF_7_0_24), "Greater than or equal for a == b shall be true.");
assertTrue(EnumUtils.ge(GF_7_0_25, GF_6_2_5), "Greater than or equal for a > b shall be true.");
assertTrue(EnumUtils.ge(GF_7_0_25, GF_7_0_25), "Greater than or equal for a == b shall be true.");
assertTrue(EnumUtils.ge(GF_4, GF_3), "Greater than or equal for a > b shall be true.");
assertTrue(EnumUtils.ge(GF_4, GF_4), "Greater than or equal for a == b shall be true.");
assertFalse(EnumUtils.ge(GF_3, GF_4), "Greater than or equal for a < b shall be false.");
Expand Down