Simplify JavaCodeTemplateFilter#accept #8794
Merged
+7
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Code cleanup
Java
|
Just a question. Were the copy made to avoid some concurrent modification exceptions? |
I don't think so. Before we had The for-loop would be able to throw CMEs too if the list is modified while iterating. I am also pretty sure that the context list is immutable. (it lists all the places where a abbreviation like "psvm" can be used, e.g CLASS level) |
list.contains() should be more efficient compared to copying the list into EnumSet + HashSet first just to call contains on them. Simpler code which doesn't catch IAEs during regular execution which would show up in JFR logs during auto completion.
mbien
force-pushed
the
simplify-java-template-filter
branch
from
9678571 to
10921f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling contains on the list should be more efficient compared to copying the list into
EnumSet+HashSetfirst just to call contains on them.Simpler code which doesn't catch IAEs during regular execution which would show up in JFR logs during auto completion.