Upgrade netbeans-gradle-tooling to use Gradle 8.11.1 #8810
+90
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on feedback on #8797, upgrade netbeans-gradle-tooling version of Gradle from 7.4 to 8.11.1. There are no expected functional changes.
The 8.11.1 version was chosen as the latest patch of the earliest version that includes API methods that overlap between those in Gradle 7/8 and what is available in Gradle 9.0.0. The strategy is to leverage javac compile-time validation on the code path closest to the current Gradle version (optimistically forward-compatible?), and use reflection only when necessary for compatibility with older versions.
Changes include:
sinceGradleOrDefault
to take ExeptionCallable as the fallback argument instead of a simple Supplier, so that the exception handling and sneakyThrows behavior can work for the fallback (e.g. when the fallback uses reflection) instead of only for the affirmative path.I updated the license files (hopefully correctly!). The previously checked-in Gradle notice file in the external dir was empty, but now it matches the NOTICE file extracted from the new distribution zip.
cc: @mbien @lkishalmi
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log
) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)