Resolves #4710 a Close Right feature in menu #8817
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An implementation of #4710
Implements an Action seen in the popup shown when right-clicking an opened file and a button in the Menu Bar. (see screenshot)
The Menu button is disabled when a different menu is selected.
IMPORTANT
I also implemented the feature in wolftxt@ee5dff6#diff-71678d0b96847081e80dbff752c8f8fbd5ddb104b0aca14c5f647b0d5577a890R330-R332
and in
wolftxt@ee5dff6#diff-bcff9302585f23230582eec38b02969456405f636b6c490c3e9c10e8c8c83e23R195
(Classes TabbedHandler and TabbedContainer)
Even through i don't think this part of the code does anything, but I implemented close right here as well just in case. I do not believe that this part of the code does anything because I was not able to reproduce any other string values of the cmd variable other than "select" or "popup".
Therefore I think that this part (along with all other parts of this method that depend on the variable cmd being any different than "select" or "popup") should be removed.