PHOENIX-7623: Add a profile which runs ITs with phoenix ha client #2205

Divneet18 · 2025-06-28T17:00:09Z

No description provided.

virajjasani · 2025-07-02T20:06:41Z

There are some merge conflicts

Divneet18 · 2025-07-22T20:11:59Z

phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java

        if (!clusterInitialized) {
            throw new IllegalStateException("Cluster must be initialized before attempting to get the URL");
        }
+        if(Boolean.parseBoolean(System.getProperty("phoenix.ha.profile.active"))){


Change to constant in HAGroup

Divneet18 · 2025-07-22T20:13:18Z

phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java

+            url = haGroup.getRoleRecord().getActiveUrl();
+            if (url.isPresent()) {
+                return url.get() + ";" + PHOENIX_TEST_DRIVER_URL_PARAM;
+            } else {


remove else block

into HA_Enabled_IT

lokiore

Took initial look, some comments and questions

one suggestion, if we have failing tests which can't be run in HA Mode, maybe exclude them in pom for HA test profile so that for default they run as it is

lokiore · 2025-07-23T23:36:15Z

phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ParallelPhoenixConnection.java

+    public ConnectionQueryServices getQueryServices() throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public PTable getTable(PTableKey key) throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public PTable getTable(String name) throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public PTable getTableNoCache(String name) throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public Consistency getConsistency() throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    @Nullable
+    public PName getTenantId() throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public MutationState getMutationState() throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public PMetaData getMetaDataCache() throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public int getMutateBatchSize() throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public int executeStatements(Reader reader, List<Object> binds, PrintStream out) throws IOException, SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public Format getFormatter(PDataType type) throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public void setRunningUpgrade(boolean isRunningUpgrade) throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public PTable getTable(String tenantId, String fullTableName) throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public PTable getTableNoCache(PName tenantId, String name) throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public void setIsClosing(boolean imitateIsClosing) throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public String getDatePattern() throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public PTable getTable(@Nullable String tenantId, String fullTableName, @Nullable Long timestamp) throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public boolean isRunningUpgrade() throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public String getURL() throws SQLException {
+        throw new UnsupportedOperationException();
+    }
+
+    @Override
+    public LogLevel getLogLevel() throws SQLException {
+        throw new UnsupportedOperationException();


Can we use runOnConnections() for these methods, we are not using parallel policy for tests but if we want to then it will be helpful?

lokiore · 2025-07-23T23:38:12Z

phoenix-core/src/it/java/org/apache/phoenix/coprocessor/StatisticsCollectionRunTrackerIT.java

 import org.junit.Test;
 import org.junit.experimental.categories.Category;
-
+//Passing with HA Connection


If all the tests in PR here are passing then we can start removing these comments

lokiore · 2025-07-23T23:40:51Z

phoenix-core/src/it/java/org/apache/phoenix/end2end/AggregateQueryWithRegionMoves2IT.java

        props.put(QueryServices.PHOENIX_POST_VALID_PROCESS,
                TestScanningResultPostValidResultCaller.class.getName());
-        setUpTestDriver(new ReadOnlyProps(props.entrySet().iterator()));
+        if(Boolean.parseBoolean(System.getProperty("phoenix.ha.profile.active"))){


Can we make phoenix.ha.profile.active a constant.

lokiore · 2025-07-23T23:42:52Z

phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java

 import org.apache.phoenix.thirdparty.com.google.common.base.Function;
 import org.apache.phoenix.thirdparty.com.google.common.collect.Lists;
-
+//Failing with HA Connection


Is this test still failing?

lokiore · 2025-07-23T23:44:31Z

phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java

+
+                } else if(e instanceof TableNotFoundException) {
+


If these exceptions are expected, then please add a comment that this is expected.

lokiore · 2025-07-24T00:05:44Z

phoenix-core/src/it/java/org/apache/phoenix/end2end/MutationStateIT.java

-import org.apache.phoenix.util.SchemaUtil;
-import org.apache.phoenix.util.StringUtil;
-import org.apache.phoenix.util.TestUtil;
+import org.apache.phoenix.util.*;


Please don't use * imports

lokiore · 2025-07-24T00:12:15Z

phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixDriverIT.java

+            conf = HBaseConfiguration.create();
+            hbaseTestUtil = new HBaseTestingUtility(conf);
+            setUpConfigForMiniCluster(conf);
+            conf.set(QueryServices.EXTRA_JDBC_ARGUMENTS_ATTRIB, QueryServicesOptions.DEFAULT_EXTRA_JDBC_ARGUMENTS);


why are we not passing this prop in conf for HA mode?

lokiore · 2025-07-24T00:12:53Z

phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixTTLToolIT.java

 * Disabling this test as this works on TTL being set on View which is removed and will be added in future.
 * TODO:- To enable this test after re-enabling TTL for view for more info check :- PHOENIX-6978
 */
+//Failing with HA Connection


This test is not being run, no change needed here

lokiore · 2025-07-24T00:13:35Z

phoenix-core/src/it/java/org/apache/phoenix/end2end/PreMatureTimelyAbortScanIt.java

    public void testPreMatureScannerAbortForCount() throws Exception {
-
-        try (Connection conn = DriverManager.getConnection(getUniqueUrl())) {
+        System.out.println("get url pls check all" + url);


clean up required here.

lokiore · 2025-07-24T00:15:20Z

phoenix-core/src/it/java/org/apache/phoenix/end2end/RegexBulkLoadToolIT.java

    }

-    @Test
+    //    @Test - ignoring local index test for HA Connection


same here don't ignore for default mode

virajjasani · 2025-10-13T00:31:14Z

Does the feature branch have spotless format? i.e. is it upto date with master branch?

PHOENIX-7623: Add a profile which runs ITs with phoenix ha client

00e3b3a

Divneet18 commented Jul 22, 2025

View reviewed changes

Divneet Kaur added 2 commits July 22, 2025 13:22

Merge branch 'PHOENIX-7623-feature' of https://github.com/apache/phoenix

b3596cf

into HA_Enabled_IT

2nd batch of tests converted to failover connection

2fec403

lokiore requested changes Jul 24, 2025

View reviewed changes

excluding failing tests and making minor changes in code:

e626c27

Divneet18 requested a review from lokiore October 10, 2025 17:40

lokiore approved these changes Oct 12, 2025

View reviewed changes

PHOENIX-7623: Add a profile which runs ITs with phoenix ha client #2205

Are you sure you want to change the base?

PHOENIX-7623: Add a profile which runs ITs with phoenix ha client #2205

Conversation

Divneet18 commented Jun 28, 2025

Uh oh!

virajjasani commented Jul 2, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lokiore left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

virajjasani commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants