PHOENIX-7695 : ParallelPhoenixResultSet keeps the unused result set open for too long #2293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 1, 2025 20:52
|
@rahulLiving There are some failures in FailoverPhoenixConnection2IT. Possibly related ? |
tkhurana
reviewed
Oct 3, 2025
| idleFuture.whenComplete((resultSet, throwable) -> { | ||
| if (throwable == null && resultSet != null) { | ||
| try { | ||
| if (!resultSet.isClosed()) { |
There was a problem hiding this comment.
I think this check is redundant. The close() is a no-op if it is already closed.
I thought so too. But all tests of |
|
@tkhurana Can you PTAL again ? Thanks |
tkhurana
approved these changes
Oct 9, 2025
meszinorbi
pushed a commit
to meszinorbi/phoenix-up
that referenced
this pull request
Oct 20, 2025
…pen for too long (apache#2293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.