PHOENIX-7707 Phoenix server paging on valid rows #2294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadirozde
reviewed
Oct 6, 2025
| long numRows = getMetricValue(metrics, MetricType.COUNT_ROWS_SCANNED); | ||
| assertEquals(expectedValidRows, numRows); | ||
| long numRpcs = getMetricValue(metrics, MetricType.COUNT_RPC_CALLS); | ||
| assertTrue(numRpcs > 1); |
There was a problem hiding this comment.
Assuming that HBase will return at most 100 rows per RPC, should this be assertTrue(numRpcs > Math.ceil(numRows / (double) 100));?
kadirozde
approved these changes
Oct 6, 2025
palashc
approved these changes
Oct 6, 2025
tkhurana
added a commit
that referenced
this pull request
Oct 9, 2025
tkhurana
added a commit
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in the patch:
next()call. The current code allocates 2 and sometimes 4 scanner context objects on everynext()call. Also, the metrics are copied from one scanner context to other. This patch only allocates one scanner context object for every rpc.