Skip to content

Add timeout to AppStoreServerAPIClient #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

Add timeout to AppStoreServerAPIClient #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions appstoreserverlibrary/api_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,7 +682,7 @@ def _make_request(self, path: str, method: str, queryParameters: Dict[str, Union
return self._parse_response(response.status_code, response.headers, lambda: response.json(), destination_class)

def _execute_request(self, method: str, url: str, params: Dict[str, Union[str, List[str]]], headers: Dict[str, str], json: Optional[Dict[str, Any]], data: Optional[bytes]) -> requests.Response:
return requests.request(method, url, params=params, headers=headers, json=json, data=data)
return requests.request(method, url, params=params, headers=headers, json=json, data=data, timeout=30)

def extend_renewal_date_for_all_active_subscribers(self, mass_extend_renewal_date_request: MassExtendRenewalDateRequest) -> MassExtendRenewalDateResponse:
"""
Expand Down Expand Up @@ -1000,7 +1000,7 @@ async def _make_request(self, path: str, method: str, queryParameters: Dict[str,
return self._parse_response(response.status_code, response.headers, lambda: response.json(), destination_class)

async def _execute_request(self, method: str, url: str, params: Dict[str, Union[str, List[str]]], headers: Dict[str, str], json: Optional[Dict[str, Any]], data: Optional[bytes]):
return await self.http_client.request(method, url, params=params, headers=headers, json=json, data=data)
return await self.http_client.request(method, url, params=params, headers=headers, json=json, data=data, timeout=30)

async def extend_renewal_date_for_all_active_subscribers(self, mass_extend_renewal_date_request: MassExtendRenewalDateRequest) -> MassExtendRenewalDateResponse:
"""
Expand Down