Skip to content

Conversation

@ahnsv
Copy link

@ahnsv ahnsv commented Sep 17, 2023

Resolve #10

Hi,
The test code gets messy to make the models (attr, pydantic) compatible.
If it feels right, I want to merge them first, refactor them and apply more validation criteria on model fields in later PRs.

@alexanderjordanbaker
Copy link
Collaborator

@ahnsv A few high level questions:

  • Is your goal to have support for attr and pydantic both going forwards?
  • Is the V1 vs V2 model approach meant to be temporary or permanent?

@ahnsv
Copy link
Author

ahnsv commented Sep 22, 2023

@alexanderjordanbaker
I think it would be better if we can replace it. In this PR, I added v2 for compatibility.
Do you think that I should make it replace it in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Suggestion] use dataclass or pydantic instead of attr for models.

5 participants