Skip to content

Conversation

smcguire-cmu
Copy link
Contributor

@smcguire-cmu smcguire-cmu commented Sep 17, 2025

Updates suffix behavior in crossmatch and join method to take a kwarg suffix_method to determine the suffix behavior. The two options currently are all_columns and overlapping_columns. all_columns applies suffixes to all columns in the catalogs, while overlapping_columns only renames the conflicting names and logs a warning with these renames.

The default currently is all_columns to match our current behavior, but there is a future warning if the user doesn't explicitly set the suffix method that the default will change in the future.

Closes #951 #911 #74

Copy link

github-actions bot commented Sep 17, 2025

Before [2a30329] <v0.6.5> After [6c58c6e] Ratio Benchmark (Parameter)
81.2±0.8ms 82.4±0.5ms 1.01 benchmarks.time_kdtree_crossmatch
889±4ms 886±5ms 1 benchmarks.time_create_midsize_catalog
5.91±0.01s 5.87±0s 0.99 benchmarks.time_create_large_catalog
39.1±0.6ms 38.2±0.7ms 0.98 benchmarks.time_polygon_search
23.9±0.3ms 23.1±0.3ms 0.97 benchmarks.time_box_filter_on_partition

Click here to view all benchmarks.

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.02%. Comparing base (57cc26a) to head (55a0e94).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
- Coverage   97.05%   97.02%   -0.03%     
==========================================
  Files          55       55              
  Lines        2712     2757      +45     
==========================================
+ Hits         2632     2675      +43     
- Misses         80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@smcguire-cmu
Copy link
Contributor Author

I updated the code with your comments. While I was adding more tests I realized the metadata ra and dec columns weren't being updated properly, so I fixed that. The metadata also had some logic about carrying over default columns, but I remember users not liking that (If they load a catalog, xmatch, save, then load and half the columns don't load). So I just got rid of the default columns logic, but I can put it back in if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suffix behavior in crossmatch/join is different to pandas and confuses users
2 participants