-
Notifications
You must be signed in to change notification settings - Fork 7
Add suffix_method
kwarg to define suffix behavior
#1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Click here to view all benchmarks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1021 +/- ##
==========================================
- Coverage 97.05% 97.02% -0.03%
==========================================
Files 55 55
Lines 2712 2757 +45
==========================================
+ Hits 2632 2675 +43
- Misses 80 82 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Melissa DeLucchi <[email protected]>
I updated the code with your comments. While I was adding more tests I realized the metadata ra and dec columns weren't being updated properly, so I fixed that. The metadata also had some logic about carrying over default columns, but I remember users not liking that (If they load a catalog, xmatch, save, then load and half the columns don't load). So I just got rid of the default columns logic, but I can put it back in if you want. |
Updates suffix behavior in crossmatch and join method to take a kwarg
suffix_method
to determine the suffix behavior. The two options currently areall_columns
andoverlapping_columns
.all_columns
applies suffixes to all columns in the catalogs, whileoverlapping_columns
only renames the conflicting names and logs a warning with these renames.The default currently is
all_columns
to match our current behavior, but there is a future warning if the user doesn't explicitly set the suffix method that the default will change in the future.Closes #951 #911 #74