Merge pull request #2183 from jaymedina/catalogs-dl-hscSpectra-typo

fixing string formatting typos in download_hsc_spectra()

Author: bsipocz

astroquery/mast/collections.py

@@ -85,8 +85,7 @@ def query_region_async(self, coordinates, radius=0.2*u.deg, catalog="Hsc",
             E.g. when using a slow internet connection.
         page : int, optional
             Default None.
-            Can be used to override the default behavior of all results being returned to
-            obtain a specific page of results.
+            Can be used to override the default behavior of all results being returned to obtain a specific page of results.
         **kwargs
             Other catalog-specific keyword args.
             These can be found in the (service documentation)[https://mast.stsci.edu/api/v0/_services.html]
@@ -466,9 +465,9 @@ def download_hsc_spectra(self, spectra, download_dir=None, cache=True, curl_flag
                 if spec['SpectrumType'] < 2:
                     data_url = f'https://hla.stsci.edu/cgi-bin/getdata.cgi?config=ops&dataset={spec["DatasetName"]}'
                 else:
-                    data_url = f'https://hla.stsci.edu/cgi-bin/ecfproxy?file_id=spec["DatasetName"].fits'
+                    data_url = f'https://hla.stsci.edu/cgi-bin/ecfproxy?file_id={spec["DatasetName"]}.fits'
 
-                local_path = os.path.join(base_dir, "{spec['DatasetName']}.fits")
+                local_path = os.path.join(base_dir, f'{spec["DatasetName"]}.fits')
 
                 status = "COMPLETE"
                 msg = None