fixing string formatting typos in download_hsc_spectra()

[jaymedina]

Closes #2182

[codecov]

Codecov Report

Merging #2183 (bfe1491) into main (7de9084) will not change coverage.
The diff coverage is 100.00%.

❗ Current head bfe1491 differs from pull request most recent head 03c8f72. Consider uploading reports for the commit 03c8f72 to get more accurate results

@@           Coverage Diff           @@
##             main    #2183   +/-   ##
=======================================
  Coverage   66.10%   66.10%           
=======================================
  Files         418      418           
  Lines       28167    28167           
=======================================
  Hits        18619    18619           
  Misses       9548     9548           

Impacted Files	Coverage Δ
astroquery/mast/collections.py	92.10% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7de9084...03c8f72. Read the comment docs.

[bsipocz]

Good spotting of the bug, thanks. One minor comment before we merge.

[jaymedina]

I'll be rebasing later today when I'm more awake. Will ping when checks pass

[jaymedina]

For some reason I get this error when trying to put the f-string in directly on that line:

  File "/Users/jmedina/Documents/gh-forks/astroquery/astroquery/mast/collections.py", line 470
    local_path = os.path.join(base_dir, f'{spec['DatasetName']}.fits')
                                                 ^
SyntaxError: f-string: unmatched '['

So I'll just call it filename instead of DatasetName

[bsipocz]

I've squashed the commits as having 5 commits for 3/4 line changes was superfluous (https://docs.astropy.org/en/latest/development/workflow/development_workflow.html#how-to-squash)

[bsipocz]

Thanks both!

[jaymedina]

Hi @bsipocz , when someone pip installs astroquery does this change come with the latest version? Our unit tests for this method are still breaking.

I'm wondering if it has something to do with the version of astroquery in pip having to be updated manually - I think I heard something along those lines being an issue at the moment?

[bsipocz]

It's not yet on pypi.