Skip to content

Conversation

snbianco
Copy link
Contributor

@snbianco snbianco commented Sep 22, 2025

Previously, for filters not related to position or request in Mast.mast_query, users had to enclose filter values in a list for the expected response from the server. This PR handles the following cases so that filters are passed in correctly:

  • Single value not in a list.
  • Numpy array.
  • Set.
  • Tuple.
  • Dictionary specifying a range of values for a continuous column.

I also added more documentation, since this was unclear to users before.

@snbianco snbianco added the mast label Sep 22, 2025
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.57%. Comparing base (c588b25) to head (302f889).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3422      +/-   ##
==========================================
+ Coverage   70.54%   70.57%   +0.02%     
==========================================
  Files         232      232              
  Lines       20022    20037      +15     
==========================================
+ Hits        14125    14141      +16     
+ Misses       5897     5896       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snbianco snbianco changed the title accepts different data types for MAST queries, tests, docs Expand the supported data types for filter values in Mast.mast_query Sep 22, 2025
@snbianco snbianco requested a review from bsipocz September 22, 2025 19:59
@snbianco snbianco marked this pull request as ready for review September 22, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant