Skip to content

Conversation

@pguyot
Copy link
Collaborator

@pguyot pguyot commented Aug 10, 2025

Kept the remove lines for release avm builds.
Added -p for runnables to prune some module (if any).
Install packbeam escript as bin/packbeam

These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).

SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later

@pguyot pguyot force-pushed the w32/single-packbeam branch 3 times, most recently from 3d8ecda to dd3936f Compare August 10, 2025 17:47
Copy link
Collaborator

@UncleGrumpy UncleGrumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement, and should simply maintenance - focusing our efforts on a single implementation of packbeam.

This should probably include a mention that it supersedes #1429.

Copy link
Collaborator

@bettio bettio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this change but I think we should vendor here the tool we use for making .avm files. So we can build without any network access and make happy people trying to use Nix.

@pguyot pguyot force-pushed the w32/single-packbeam branch from dd3936f to a4d5477 Compare October 5, 2025 08:27
@UncleGrumpy
Copy link
Collaborator

UncleGrumpy commented Oct 5, 2025

Would including atomvm_packbeam here as a git submodule be enough to keep the nix people happy?
I think it is best kept as a stand alone repo since the atomvm_rebar3_plugin (and maybe eventually ExAtomVM) depend on it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants