Skip to content

Conversation

@petermm
Copy link

@petermm petermm commented Nov 1, 2025

Copy link

@UncleGrumpy UncleGrumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest using external .license files for upstream sources, rather than modifying them.

@UncleGrumpy
Copy link

Maybe we need to update the file(s) from upstream, because the header in the version we are using is not MIT, it clearly states “unlicense”.

@petermm
Copy link
Author

petermm commented Nov 2, 2025

Maybe we need to update the file(s) from upstream, because the header in the version we are using is not MIT, it clearly states “unlicense”.

It's upstream issue the latest files still states the same - https://github.com/richgel999/miniz/blob/master/miniz.h

richgel999/miniz#127 - open since 2019 - I believe it's safe to mark as MIT as it's the most restrictive of the two (MIT vs unlicense).

But no strong feelings, just wanted green CI;-)

@UncleGrumpy
Copy link

No strong feelings here either, just want to make sure the suits don’t come after us ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants