Skip to content

Modified the loop that counts non-ASCII characters in _string_from_ge… #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modified the loop that counts non-ASCII characters in _string_from_ge… #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/pcremodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

#include <Python.h>
#include <structmember.h>
#include <stdint.h>

#include <pcre.h>

Expand Down Expand Up @@ -127,10 +128,17 @@ _string_get_from_bytes(pypcre_string_t *str, PyObject *op, int *options,
if (!(*options & PCRE_UTF8)) {
*options |= PCRE_NO_UTF8_CHECK;

/* Count non-ascii bytes. */
for (p = start; p < end; ++p) {
if (*p > 127)
++count;
/* Count non-ascii bytes. This loop tries to operate in a "vectorized"
* manner, operating on 8 bytes at a time when possible. */
unsigned int remainder = view->len % sizeof(uint64_t);
for (p = start; p < end - remainder; p += sizeof(uint64_t)) {
/* Mask off the top bits of each byte. */
uint64_t temp = *(uint64_t*)p & 0x8080808080808080ULL;
/* Count how many of them are set, and add the count to "count". */
count += __builtin_popcountll(temp);
}
for (p = end - remainder; p < end; ++p) {
count += (*p & 0x80) >> 7;
}
}

Expand Down