fix(chat): session context paths aren't serializable #3009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes database serialization errors when using added context files. Root cause: Session context paths (from /context add) were failing serialization with a silent "Session paths are not serialized" error, preventing conversation state from being saved to the database. Changes: - Add custom serializer for ContextManager.paths that filters out session paths - Session paths are now excluded from database persistence (as originally intended) - Replace silent .ok() error handling with proper tracing logging Testing: - Add unit test for serialization filtering behavior - Verify conversation persistence works with mixed agent/session contexts This maintains the intended behavior where session context is temporary while fixing database persistence for conversations with non-default agents. Fixes aws#3008
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3008
Description of changes:
Fixes database serialization errors when using added context files.
Root cause: Session context paths (from
/context add) were failing serialization with a silent "Session paths are not serialized" error, preventing conversation state from being saved to the database.Changes:
.ok()error handling with proper tracing loggingTesting:
This maintains the intended behavior where session context is temporary while fixing database persistence for conversations with non-default agents.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.