Skip to content

Disable support for '-fls' option in find command for security reasone #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Disable support for '-fls' option in find command for security reasone #3033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/chat-cli/src/cli/chat/tools/execute/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ impl ExecuteCommand {
|| arg.contains("-delete")
|| arg.contains("-ok") // includes -okdir
|| arg.contains("-fprint") // includes -fprint0 and -fprintf
|| arg.contains("-fls")
}) =>
{
return true;
Expand Down Expand Up @@ -320,6 +321,7 @@ mod tests {
("find important-dir/ -exec rm {} \\;", true),
("find . -name '*.c' -execdir gcc -o '{}.out' '{}' \\;", true),
("find important-dir/ -delete", true),
("find important-dir/ -fls /etc/passwd", true),
(
"echo y | find . -type f -maxdepth 1 -okdir open -a Calculator {} +",
true,
Expand Down