feat: add Stop hook #3070
Merged
feat: add Stop hook #3070
+80
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erbenmo
reviewed
Oct 1, 2025
docs/hooks.md
Outdated
| - **0**: Hook succeeded. | ||
| - **Other**: Show STDERR warning to user. Tool already ran. | ||
|
|
||
| ### EndOfTurn |
There was a problem hiding this comment.
Can we update the "Available hook triggers" under https://github.com/aws/amazon-q-developer-cli/blob/main/docs/agent-format.md#hooks-field as well?
There was a problem hiding this comment.
done, also renamed to Stop per our offline conversation
erbenmo
approved these changes
Oct 1, 2025
dk19y
approved these changes
Oct 2, 2025
hugoncosta
force-pushed
the
end-of-turn
branch
from
6311680 to
d357135
Compare
hugoncosta
force-pushed
the
end-of-turn
branch
from
d357135 to
d6d5a43
Compare
dk19y
approved these changes
Oct 2, 2025
kkashilk
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3034
Description of changes:
See #2875 for the initial implementation. Sometimes, the Agents run the tools several times in a particular turn (e.g. when writing code, they don't write the whole thing at once, especially when dealing with already existing files).
With this feature, you can set your hook to only run at the end of the turn, allowing you to only run e.g. formatting/tests when the whole file is written.
Tested locally, it's working as intended - only after doing all the fs_write did it do the formatting (I used the example currently in the hooks.md that runs cargo fmt after it's done).
This is a simplified version of what I had originally proposed in #3036, more in line with industry expectations as well.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.