Add support for Feature specification for ComputeResources
#3020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demartinofra
reviewed
Oct 9, 2025
| self.disable_multithreading = compute_resource_config["DisableSimultaneousMultithreading"] | ||
| self.custom_settings = compute_resource_config.get("CustomSlurmSettings", {}) | ||
| # If Features are in CustomSlurmSettings, fetch them and remove from CustomSlurmSettings | ||
| self.custom_features = self.custom_settings.pop("Feature", "") |
There was a problem hiding this comment.
Instead of mutating the custom_settings object by removing features I would keep custom_settings aligned with what is injected from config and filter out features when building the custom += f" {param}={value}" string as part of the nodename rendering.
Comment on lines
+91
to
+93
| # this is a simple workaround for empty Features: split will give [''] and we'll discard it | ||
| # as well as all empty strings. | ||
| features.discard('') |
There was a problem hiding this comment.
default to None when reading the Feature string and skip the splitting so that you don't need to discard ''?
Comment on lines
+95
to
+97
| # remove "system" features from configured features, so that they will never interfere | ||
| for feat in ('static', 'dynamic', 'gpu', 'efa') : | ||
| features.discard(feat) |
There was a problem hiding this comment.
you could consider leaving these unaltered - if for any reason the user passes them in we could just honor them as overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
With this changes, users will be able to specify additional
Featurevalues for ComputeResources. ThoseFeature-s will be safely added to the Slurm nodes specification for the partition.Rationale: In many cases, especially with complex cluster setups, it's crucial to have additional
Feature-s that can be used to filter nodes for the jobs.Tests
Added the following tests:
test/unit/slurm/test_slurm_config_generator.py::test_generate_slurm_config_with_custom_features- tests config generation with custom features specified. Corresponding test data is intest/unit/slurm/test_generate_slurm_config_with_custom_features.NOTE: test data for many tests were changed because the new features generation algorithm requires all features in
Feature=...in config files to be sorted. So many test files were affected, but the only change that were made to them is features ordering.References
This PR has a complimentary PR in
aws-parallelclusterrepo: aws/aws-parallelcluster#6962By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.