Skip to content

Fix missing put metrics #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 8, 2025
Merged

Fix missing put metrics #341

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb49f1d
add both failure and success update
sage-maker Sep 2, 2025
ae36f3b
fix a whitespace
sage-maker Sep 2, 2025
4565931
Merge branch 'main' into fix-missing-metrics
sage-maker Sep 8, 2025
ce63601
fix: remove * and use checkout@v4
sage-maker Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/pr-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12" ]

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up Python ${{ matrix.python-version }}
Expand Down Expand Up @@ -183,7 +183,7 @@ jobs:
- name: Execute Python Coverage compute script and capture output
id: execute_coverage_parse_script
run: |
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }}* ]]; then
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }} ]]; then
aws cloudwatch put-metric-data --metric-name UnitTestCoverage --namespace SageMakerPySdkCoreMonitoringMetrics --value $(python workflow_helper/compute_resource_coverage.py) --unit Count --dimensions MetricCategory=Unit-${{ matrix.python-version }}
else
echo "Putting metrics has been skipped"
Expand All @@ -208,7 +208,7 @@ jobs:
role-duration-seconds: 10800
- name: Execute Boto API Coverage compute script and capture output
run: |
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }}* ]]; then
if [[ "${{ github.event.pull_request.user.login }}" == ${{ secrets.SAGEMAKER_BOT_USER_LOGIN }} ]]; then
output=$(python workflow_helper/compute_boto_api_coverage.py)
unsupported_apis=$(echo $output | cut -d ' ' -f1)
supported_apis=$(echo $output | cut -d ' ' -f2)
Expand All @@ -221,7 +221,7 @@ jobs:
runs-on: ubuntu-latest
needs: [wait-for-approval]
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Set up Python
Expand Down