Skip to content

Revert Commits That Disable Pytorch Tests For 1.7 #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Revert Commits That Disable Pytorch Tests For 1.7 #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
458fa7d
Revert "pytorch tmp (#382)"
NihalHarish Oct 28, 2020
30b3a2c
Revert "disable pytorch (#386)"
NihalHarish Oct 28, 2020
1dcfbbb
Merge branch 'master' into revert_changes
NihalHarish Oct 29, 2020
071b05d
Merge branch 'master' into revert_changes
leleamol Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 2 additions & 14 deletions tests/zero_code_change/pt_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,34 +7,22 @@
import torch.nn.functional as F
import torchvision
import torchvision.transforms as transforms
from packaging import version


def get_dataloaders() -> Tuple[torch.utils.data.DataLoader, torch.utils.data.DataLoader]:
transform = transforms.Compose(
[transforms.ToTensor(), transforms.Normalize((0.5, 0.5, 0.5), (0.5, 0.5, 0.5))]
)

# Temporary Change to allow the test to run with pytorch 1.7 RC3
# Smdebug breaks when num_workers>0 for Pytorch 1.7.0
if version.parse(torch.__version__) >= version.parse("1.7.0"):
num_workers = 0
else:
num_workers = 2

trainset = torchvision.datasets.CIFAR10(
root="./data", train=True, download=True, transform=transform
)
trainloader = torch.utils.data.DataLoader(
trainset, batch_size=4, shuffle=True, num_workers=num_workers
)
trainloader = torch.utils.data.DataLoader(trainset, batch_size=4, shuffle=True, num_workers=2)

testset = torchvision.datasets.CIFAR10(
root="./data", train=False, download=True, transform=transform
)
testloader = torch.utils.data.DataLoader(
testset, batch_size=4, shuffle=False, num_workers=num_workers
)
testloader = torch.utils.data.DataLoader(testset, batch_size=4, shuffle=False, num_workers=2)

classes = ("plane", "car", "bird", "cat", "deer", "dog", "frog", "horse", "ship", "truck")
return trainloader, testloader
Expand Down
5 changes: 0 additions & 5 deletions tests/zero_code_change/test_pytorch_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

# Third Party
import pytest
import torch
import torch.nn as nn
import torch.nn.functional as F
import torch.optim as optim
Expand All @@ -23,10 +22,6 @@
from smdebug.core.utils import SagemakerSimulator, ScriptSimulator


@pytest.mark.skipif(
torch.__version__ == "1.7.0",
reason="Disabling the test temporarily until we root cause the version incompatibility",
)
@pytest.mark.parametrize("script_mode", [False])
@pytest.mark.parametrize("use_loss_module", [True, False])
def test_pytorch(script_mode, use_loss_module):
Expand Down