Skip to content

Conversation

NihalHarish
Copy link
Contributor

Description of changes:

  • We should ignore special status files that can be added by Sagemaker before determining if we should update the checkpointing directory.

Style and formatting:

I have run pre-commit install to ensure that auto-formatting happens with every commit.

Issue number, if available

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Mar 23, 2021

Codecov Report

Merging #470 (2897643) into master (1aac94b) will decrease coverage by 15.52%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #470       +/-   ##
===========================================
- Coverage   65.53%   50.00%   -15.53%     
===========================================
  Files         173      163       -10     
  Lines       13280    12934      -346     
===========================================
- Hits         8703     6468     -2235     
- Misses       4577     6466     +1889     
Impacted Files Coverage Δ
smdebug/core/state_store.py 77.58% <ø> (-3.45%) ⬇️
smdebug/_version.py 100.00% <100.00%> (ø)
smdebug/tensorflow/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
smdebug/tensorflow/constants.py 0.00% <0.00%> (-100.00%) ⬇️
smdebug/tensorflow/singleton_utils.py 0.00% <0.00%> (-100.00%) ⬇️
smdebug/tensorflow/collection.py 0.00% <0.00%> (-95.88%) ⬇️
smdebug/tensorflow/session.py 0.00% <0.00%> (-91.83%) ⬇️
smdebug/tensorflow/keras.py 0.00% <0.00%> (-89.30%) ⬇️
smdebug/tensorflow/tensor_ref.py 0.00% <0.00%> (-88.71%) ⬇️
smdebug/tensorflow/utils.py 0.00% <0.00%> (-86.26%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aac94b...2897643. Read the comment docs.

@@ -1 +1 @@
__version__ = "1.0.8"
__version__ = "1.0.8b"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

file != METADATA_FILENAME
and file != METADATA_FILENAME_S3_UPLOADED
and "sagemaker-uploaded" not in file
and "sagemaker-uploading" not in file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This won't scale well. Can we keep track of a list of files not to append and then do something like:

if all([metadata_file not in file for metadata_file in metadata_files]) 

@NihalHarish NihalHarish changed the title Ignore sagemaker-uploading [Do-Not-Merge] Ignore sagemaker-uploading Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants