Issue #21: Fix actions for views bulk operations, add message when th… #22
Conversation
jenlampton
force-pushed
the
21-flag-actions
branch
from
658c99c to
d5bac82
Compare
… message when they can't act.
jenlampton
force-pushed
the
21-flag-actions
branch
from
d5bac82 to
9b53ae0
Compare
herbdool
left a comment
herbdool
left a comment
There was a problem hiding this comment.
This PR works fine. I've left a couple comments - the configuration form won't work with core's version of bulk operations.
| /** | ||
| * Form for configuring the Flag node action. | ||
| */ | ||
| function flag_node_action_form($context = array()) { |
There was a problem hiding this comment.
I'm not sure if these get called. From what I recall, core version of Bulk Actions didn't include the ability to have forms for configuring actions.
There was a problem hiding this comment.
Interested in this -- I have the same issue with a few modules I was trying to port in my spare time (e.g. node convert, organic groups I think).
| */ | ||
|
|
||
| /** | ||
| * Implements Drupal action. Flags any entity. |
There was a problem hiding this comment.
Should be "Backdrop action".
| /** | ||
| * Form for configuring the Flag node action. | ||
| */ | ||
| function flag_node_action_form($context = array()) { |
There was a problem hiding this comment.
I'm not sure if these get called. From what I recall, core version of Bulk Actions didn't include the ability to have forms for configuring actions.
|
|
||
| /** | ||
| * Implements hook_init(). | ||
| * Implements hook_action_info(). |
There was a problem hiding this comment.
Just noticed this is in flag.module. Shouldn't it be in flag_actions.module?
3 participants
Fixes #21
IAS