-
Notifications
You must be signed in to change notification settings - Fork 5
Issue #22: Add support for CKEditor 5. #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.x-1.x
Are you sure you want to change the base?
Issue #22: Add support for CKEditor 5. #24
Conversation
|
Many thanks @quicksketch - I've tested this PR and can confirm it works with CKEditor 5. |
|
@nattywebdev Thanks for testing! Do you mean that every time you insert a file, it creates a new paragraph tag? It should respect where the cursor is in the document, but I admit I did not test that level. It's entirely likely the the code I used will always wrap the newly inserted content in |
|
Revisiting this after the break and I find that the additional tags are now not inserted in my example. No idea what caused that issue before but my current example works just fine:
So thank you @quicksketch ! |
|
That's great, thank you @nattywebdev. However, now that backdrop/backdrop-issues#6770 has been released in 1.29.3, we can improve this code to use the new variable provided by CKEditor 5 core, so we don't have to track the instance ourselves. This can be merged as-is, but it could be improved by now removing the manual tracking. |
|
@quicksketch is this now dealt with by backdrop/backdrop-issues#6770 ? Or is something needed in the Insert module to access the relevant variable? I have no clue how to do that so will need help. |
Fixes #22. This also removes some support that is not applicable to Backdrop, including: