Skip to content

Conversation

ryan-williams
Copy link
Member

fixes #37

I think this should be merge-able whenever, though the corresponding version-bump in ADAM will have to go along with the corresponding refactor over there, which I have locally built off of ADAM#664 and will file shortly, for merging whenever we're ready to actually do that upgrade, or cut a branch that includes backwards-incompatible changes from bdg-utils-0.2.1

@fnothaft
Copy link
Member

fnothaft commented May 3, 2015

Will merge as soon as build runs. I can cut a release after it merges, so that we can get it in to ADAM. I'll update bigdatagenomics/adam#664 with the 0.2.1 release. Do you want to PR your changes against my bigdatagenomics/adam#664 branch? That might be the cleanest way to do things.

@AmplabJenkins
Copy link

Merged build triggered.

@AmplabJenkins
Copy link

Merged build started.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/bdg-utils-prb/42/
Test PASSed.

fnothaft added a commit that referenced this pull request May 3, 2015
kill `job` argument to BDGSparkCommand
@fnothaft fnothaft merged commit 6e90fb0 into bigdatagenomics:master May 3, 2015
@fnothaft
Copy link
Member

fnothaft commented May 3, 2015

Merged! Thanks @ryan-williams!

@ryan-williams
Copy link
Member Author

haha, I was about to PR my changes against your #664 and apologize for the complexity of that; glad you think that is "the cleanest way" :)

I build mvn installd my utils:0.2.1-SNAPSHOT with this PR merged in and am building ADAM against that local utils:0.2.1-SNAPSHOT. As soon as that passes I'll send my PR against #664.

@fnothaft
Copy link
Member

fnothaft commented May 3, 2015

haha, I was about to PR my changes against your #664 and apologize for the complexity of that; glad you think that is "the cleanest way" :)

Great minds... ;)

I build mvn installd my utils:0.2.1-SNAPSHOT with utils#38 merged in and am building ADAM against that local utils:0.2.1-SNAPSHOT. As soon as that passes I'll send my PR against #664.

Sounds great. I'm starting the release process now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kill Job argument to BDGSparkCommand
3 participants