Skip to content

Security issue: Library-created, world-readable config file may contain secrets #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Security issue: Library-created, world-readable config file may contain secrets #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51eca1f
write config file with mode 600 as it may contain secrets
iskunk Sep 29, 2021
f539b26
don't write config file by default, as it may contain secrets
iskunk Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion blackduck/Core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
import os
import requests
import json
from operator import itemgetter
Expand All @@ -17,7 +18,9 @@ def read_config(self):
raise

def write_config(self):
with open(self.configfile,'w') as f:
def openfn(cfg, flags):
return os.open(cfg, flags, mode=0o600)
with open(self.configfile, 'w', opener=openfn) as f:
json.dump(self.config, f, indent=3)

def get_auth_token(self):
Expand Down
2 changes: 1 addition & 1 deletion blackduck/HubRestApi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def __init__(self, *args, **kwargs):
self.config['insecure'] = kwargs.get('insecure', False)
self.config['debug'] = kwargs.get('debug', False)

if kwargs.get('write_config_flag', True):
if kwargs.get('write_config_flag', False):
self.write_config()
except Exception:
self.read_config()
Expand Down