Skip to content

Conversation

JonathanSerafini
Copy link
Contributor

No description provided.

@JonathanSerafini JonathanSerafini marked this pull request as ready for review April 30, 2025 12:55
@JonathanSerafini JonathanSerafini requested a review from a team as a code owner April 30, 2025 12:55
@JonathanSerafini JonathanSerafini marked this pull request as draft April 30, 2025 12:59
@JonathanSerafini JonathanSerafini marked this pull request as ready for review April 30, 2025 13:07
@scott-boost scott-boost requested a review from Copilot April 30, 2025 13:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores backwards compatibility for the ci_docker_proxy configuration in the CI pipeline.

  • Adds conditional logic in scanner.yml to set CI_DOCKER_PROXY if BOOST_DOCKER_PROXY is set and CI_DOCKER_PROXY is not.
  • Implements separate handling for "group" and "direct" values of BOOST_DOCKER_PROXY.
Comments suppressed due to low confidence (2)

scanner.yml:51

  • Consider using a single '=' for string comparison in POSIX shells, unless this script is guaranteed to run in Bash.
if [ "${BOOST_DOCKER_PROXY:-}" == "group" ]; then

scanner.yml:53

  • Consider using a single '=' for string comparison in POSIX shells, unless this script is guaranteed to run in Bash.
elif [ "${BOOST_DOCKER_PROXY:-}" == "direct" ]; then

@JonathanSerafini JonathanSerafini merged commit 4b698a3 into main Apr 30, 2025
4 checks passed
@JonathanSerafini JonathanSerafini deleted the fix-proxy branch April 30, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants