Skip to content

Conversation

Johan-Liebert1
Copy link
Collaborator

@Johan-Liebert1 Johan-Liebert1 commented Sep 24, 2025

Finish up implementation for install-to-filesystem for composefs-backend

We were using composefs-native and composefs-backend interchangeably.
Replace all instances of composefs-native with composefs-backend

Move all composefs-backend options to a single struct so that we can
test for boolean instead of testing for Some/None for composefs-backend
options

The source imgref was being stored in the .origin file, even if target imgref was
provided. Now we store the target imgref

Start finalize-staged service on update/switch

Add composefs opts to install-to-existing-root

@bootc-bot bootc-bot bot requested a review from jeckersb September 24, 2025 10:26
@Johan-Liebert1 Johan-Liebert1 force-pushed the composefs-to-filesystem branch from b4cd3c2 to 6134880 Compare October 8, 2025 06:07
@github-actions github-actions bot added the area/install Issues related to `bootc install` label Oct 8, 2025
@Johan-Liebert1 Johan-Liebert1 force-pushed the composefs-to-filesystem branch 2 times, most recently from 2300293 to 82ee61e Compare October 8, 2025 06:43
We were using composefs-native and composefs-backend interchangeably.
Replace all instances of `composefs-native` with `composefs-backend`

Move all composefs-backend options to a single struct so that we can
test for boolean instead of testing for Some/None for composefs-backend
options

Signed-off-by: Pragyan Poudyal <[email protected]>
Instead of storing the source imgref in the .origin file, we store the
target imgref

Signed-off-by: Pragyan Poudyal <[email protected]>
@Johan-Liebert1 Johan-Liebert1 force-pushed the composefs-to-filesystem branch from 82ee61e to ebe252c Compare October 8, 2025 08:06
@Johan-Liebert1 Johan-Liebert1 marked this pull request as ready for review October 8, 2025 08:24
@bootc-bot bootc-bot bot requested a review from henrywang October 8, 2025 08:25
@Johan-Liebert1 Johan-Liebert1 changed the title composese-backend: Implement install to filesystem New changes / features for composefs-backend Oct 8, 2025
@Johan-Liebert1 Johan-Liebert1 added the area/composefs Issues related to composefs label Oct 8, 2025
@Johan-Liebert1
Copy link
Collaborator Author

Currently with the option --bootloader=systemd we do everything according to the BLS spec, but the bootloader is still grub, as we don't have systemd-boot support in bootupd. Until coreos/bootupd#978 lands, I was thinking of a very crude hack of simply replacing grubx64.efi with systemd-boot.efi (renamed to grubx64.efi so shim picks it up); this is basically how I've been testing systemd-boot until now.

Does it make sense to do the above until we have systemd-boot support in bootupd?

@cgwalters
Copy link
Collaborator

Yes I'll try to take a look at coreos/bootupd#978 soon.

Otherwise see #806 (comment) - I think the "no bootupd = systemd-boot" path also makes sense and should be relatively straightforward to implement here.

@cgwalters
Copy link
Collaborator

Ah my bad, I think we have some textual (partial semantic) conflicts in #1662

@Johan-Liebert1
Copy link
Collaborator Author

That's okay. I can rebase on main afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/composefs Issues related to composefs area/install Issues related to `bootc install`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants