Skip to content

Conversation

cgwalters
Copy link
Collaborator

Make builds unprivileged by default and start using bcvk in our own CI, the same way we expect people to do so locally now.

@bootc-bot bootc-bot bot requested a review from henrywang October 10, 2025 11:09
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CI and local build process to use bcvk for creating disk images, which simplifies the process and allows for unprivileged builds. The changes in the Justfile are a great simplification. In the GitHub Action workflow, I've noticed that the script to install bcvk is hardcoded for the x86_64 architecture, which would cause issues for multi-arch builds. I've provided a suggestion to make the installation script architecture-agnostic and more robust.

@cgwalters
Copy link
Collaborator Author

Error: reading blob sha256:70bccdb16279fab744edcf78bf4ef42ca06cddc350ad437cfd1d0a0f1702d3b8: open /run/virtiofs-mnt-hoststorage/overlay/70bccdb16279fab744edcf78bf4ef42ca06cddc350ad437cfd1d0a0f1702d3b8/diff/usr/lib64/python3.9/profile.py: too many open files

I think this is https://gitlab.com/virtio-fs/virtiofsd/-/issues/210 - investigating.

@cgwalters
Copy link
Collaborator Author

OK yep bootc-dev/bcvk#60 will fix this

Make builds unprivileged by default and start using bcvk in
our own CI, the same way we expect people to do so locally
now.

Signed-off-by: Colin Walters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant