-
Notifications
You must be signed in to change notification settings - Fork 7
renovate.json: Remove platform-engineering-org inheritance #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This removes the inheritance from platform-engineering-org/.github to fix the 'Edited' warning that prevents Renovate from automatically rebasing PRs. The warning occurs because Renovate doesn't recognize bootc-bot as a valid commit author. Fixes: bootc-dev/infra#19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @cgwalters, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request modifies the Renovate configuration to resolve an issue that was preventing automated rebase of pull requests. By adjusting the configuration, it ensures that Renovate can correctly recognize its own bot's commits, thereby enabling the intended automated dependency update workflows.
Highlights
- Renovate Configuration Update: Removed the "extends" property from
renovate.json
, which previously inherited configuration fromgithub>platform-engineering-org/.github
. This change aims to fix an "Edited" warning that prevented Renovate from automatically rebasing pull requests, as thebootc-bot
was not recognized as a valid commit author under the inherited configuration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the inherited Renovate configuration to resolve a warning that prevents automatic rebasing. While this addresses the issue, it's important to note that this change causes the repository to fall back to Renovate's default configuration. This could result in a significant change in behavior if the inherited configuration contained important custom rules. I've added a comment to highlight this and suggest migrating any necessary configuration directly into this file to ensure continued expected behavior.
@cgwalters missing signed-off-by |
@cgwalters ping |
This removes the inheritance from platform-engineering-org/.github to fix the 'Edited' warning that prevents Renovate from automatically rebasing PRs.
The warning occurs because Renovate doesn't recognize bootc-bot as a valid commit author when it's configured through the inherited configuration.
See bootc-dev/infra#19 for context.
This is part of a batch update across all bootc-dev repositories.