bpwilcox · vertueux · May 12, 2024 · May 12, 2024 · May 12, 2024
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -7,7 +7,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  add_compile_options(-Wall -Wextra -Wpedantic -fPIC)
+  add_compile_options(-Wall -Wpedantic -fPIC)
 endif()
 
 find_package(ament_cmake REQUIRED)
@@ -21,16 +21,16 @@ include_directories(
 link_directories(${ament_LIBRARY_DIRS})
 
 add_library(xmlrpcpp
-  src/XmlRpcClient.cpp
+  src/xml_rpc_client.cc
 	#TODO(bpwilcox):port for ROS2 
-  #src/XmlRpcDispatch.cpp  
-  src/XmlRpcServer.cpp
-  src/XmlRpcServerConnection.cpp
-  src/XmlRpcServerMethod.cpp
-  src/XmlRpcSocket.cpp
-  src/XmlRpcSource.cpp
-  src/XmlRpcUtil.cpp
-  src/XmlRpcValue.cpp
+  #src/xml_rpc_Dispatch.cc  
+  src/xml_rpc_server.cc
+  src/xml_rpc_server_connection.cc
+  src/xml_rpc_server_method.cc
+  src/xml_rpc_socket.cc
+  src/xml_rpc_source.cc
+  src/xml_rpc_util.cc
+  src/xml_rpc_value.cc
   libb64/src/cdecode.c
   libb64/src/cencode.c
 )

diff --git a/LICENSE b/LICENSE
diff --git a/README.html → README.md b/README.html → README.md
@@ -1,17 +1,15 @@
-<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
 <html>
 	<head>
-		<title>XmlRpc++ Library</title>
 		<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
 		<meta http-equiv="Content-language" content="en-US">
 		<meta name="author" content="Chris Morley">
-		<meta name="copyright" content="Copyright � 2003 by Chris Morley">
+		<meta name="copyright" content="Copyright � 2003 by Chris Morley">
 	</head>
 	<body>
 		<H3>XmlRpc++ Library</H3>
 		<P>This is version 0.7 of XmlRpc++, an implementation of the <A HREF="http://www.xmlrpc.org">
-				XmlRpc protocol</A> written in C++, based upon Shilad Sen's excellent <A HREF="http://py-xmlrpc.sourceforge.net">
-				py-xmlrpc library</A>. XmlRpc++ is designed to make it easy to incorporate 
+			XmlRpc protocol</A> written in C++, based upon Shilad Sen's excellent <A HREF="http://py-xmlrpc.sourceforge.net">
+			py-xmlrpc library</A>. XmlRpc++ is designed to make it easy to incorporate 
 			XmlRpc client and server support into C++ applications. Or use both client and 
 			server objects in your app for easy peer-to-peer support.
 		</P>

diff --git a/src/XmlRpcClient.cpp → src/xml_rpc_client.cc b/src/XmlRpcClient.cpp → src/xml_rpc_client.cc
diff --git a/src/XmlRpcDispatch.cpp → src/xml_rpc_dispatch.cc b/src/XmlRpcDispatch.cpp → src/xml_rpc_dispatch.cc
diff --git a/src/XmlRpcServer.cpp → src/xml_rpc_server.cc b/src/XmlRpcServer.cpp → src/xml_rpc_server.cc
@@ -29,7 +29,7 @@ XmlRpcServer::XmlRpcServer()
     _accept_retry_time_sec(0.0)
 {
 #if !defined(_WINDOWS)
-  struct rlimit limit = { .rlim_cur = 0, .rlim_max = 0 };
+  struct rlimit limit = { 0, 0 };
   unsigned int max_files = 1024;
 
   if(getrlimit(RLIMIT_NOFILE, &limit) == 0) {
@@ -223,7 +223,7 @@ int XmlRpcServer::countFreeFDs() {
 #if !defined(_WINDOWS)
   int free_fds = 0;
 
-  struct rlimit limit = { .rlim_cur = 0, .rlim_max = 0 };
+  struct rlimit limit = { 0, 0 };
 
   // Get the current soft limit on the number of file descriptors.
   if(getrlimit(RLIMIT_NOFILE, &limit) == 0) {

diff --git a/src/XmlRpcServerConnection.cpp → src/xml_rpc_server_connection.cc b/src/XmlRpcServerConnection.cpp → src/xml_rpc_server_connection.cc
@@ -76,7 +76,7 @@ XmlRpcServerConnection::readHeader()
   // Read available data
   bool eof;
   if ( ! XmlRpcSocket::nbRead(this->getfd(), _header, &eof)) {
-    // Its only an error if we already have read some data
+    // It's only an error if we already have read some data
     if (_header.length() > 0)
       XmlRpcUtil::error("XmlRpcServerConnection::readHeader: error while reading header (%s).",XmlRpcSocket::getErrorMsg().c_str());
     return false;

diff --git a/src/XmlRpcServerMethod.cpp → src/xml_rpc_server_method.cc b/src/XmlRpcServerMethod.cpp → src/xml_rpc_server_method.cc
diff --git a/src/XmlRpcSocket.cpp → src/xml_rpc_socket.cc b/src/XmlRpcSocket.cpp → src/xml_rpc_socket.cc
diff --git a/src/XmlRpcSource.cpp → src/xml_rpc_source.cc b/src/XmlRpcSource.cpp → src/xml_rpc_source.cc
diff --git a/src/XmlRpcUtil.cpp → src/xml_rpc_util.cc b/src/XmlRpcUtil.cpp → src/xml_rpc_util.cc
diff --git a/src/XmlRpcValue.cpp → src/xml_rpc_value.cc b/src/XmlRpcValue.cpp → src/xml_rpc_value.cc
diff --git a/standalone-tests/FileClient.cpp b/standalone-tests/FileClient.cpp
@@ -3,7 +3,7 @@
 // 
 // Link against xmlrpc lib and whatever socket libs your system needs (ws2_32.lib on windows)
 
-#include "xmlrpcpp/XmlRpc.h"
+#include "xmlrpcpp/XmlRpc.h"
 #include <iostream>
 #include <fstream>
 #include <stdlib.h>

diff --git a/standalone-tests/TestBase64Client.cpp b/standalone-tests/TestBase64Client.cpp
@@ -5,7 +5,7 @@
 // Requests a png file from the specified server and saves it in outputfile.
 // Link against xmlrpc lib and whatever socket libs your system needs (ws2_32.lib on windows)
 
-#include "xmlrpcpp/XmlRpc.h"
+#include "xmlrpcpp/XmlRpc.h"
 #include <iostream>
 #include <fstream>
 #include <stdlib.h>

diff --git a/standalone-tests/TestBase64Server.cpp b/standalone-tests/TestBase64Server.cpp
@@ -11,7 +11,7 @@
 #include <stdlib.h>
 
 
-#include "xmlrpcpp/XmlRpc.h"
+#include "xmlrpcpp/XmlRpc.h"
 using namespace XmlRpc;
 
 

diff --git a/standalone-tests/TestValues.cpp b/standalone-tests/TestValues.cpp
@@ -2,7 +2,7 @@
 
 #include <stdlib.h>
 
-#include "xmlrpcpp/XmlRpcValue.h"
+#include "xmlrpcpp/XmlRpcValue.h"
 
 
 #include <assert.h>

diff --git a/standalone-tests/TestValuesWin32.cpp b/standalone-tests/TestValuesWin32.cpp
@@ -4,7 +4,7 @@
 #include <stdlib.h>
 #include <crtdbg.h>
 
-#include "xmlrpcpp/XmlRpcValue.h"
+#include "xmlrpcpp/XmlRpcValue.h"
 
 
 #include <assert.h>

diff --git a/standalone-tests/TestXml.cpp b/standalone-tests/TestXml.cpp
@@ -11,7 +11,7 @@
 #include <assert.h>
 #include <stdlib.h>
 
-#include "xmlrpcpp/XmlRpcUtil.h"
+#include "xmlrpcpp/XmlRpcUtil.h"
 
 using namespace XmlRpc;
 

diff --git a/standalone-tests/Validator.cpp b/standalone-tests/Validator.cpp
@@ -1,6 +1,6 @@
 // Validator.cpp : XMLRPC server based on the compliancy test at validator.xmlrpc.com.
 //
-#include "xmlrpcpp/XmlRpc.h"
+#include "xmlrpcpp/XmlRpc.h"
 using namespace XmlRpc;
 
 #include <iostream>