Dev #2
Open
Dev #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Howdy Brett,
I have changed the getHomeDir() method in AppConfig class slightly as it didn't work cleanly on Windows so I have introduced a config property that can deliberately set the home folder and then check for this first before falling back to checking the existing properties/env variables it currently checks.
I have also changed H2DBBackup class slightly to also look for a config property to specify the backup folder before it defaults to a backup subfolder in the home folder, I have also included the app name in the backup filename if one is set, otherwise, it defaults to the current naming convention of app-db-backup.
EDIT:
This is a second attempt as I have changed the getPath() call to getString() on the first property check for getHomeDir() as the app was bombing if the property didn't exist (NullPointerException) and I couldn't figure out why. Swapping methods solved the problem.