Fix GSL for C++ standalone mode #1687
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might hide actual problems, since some places (e.g. GSL) use `NotImplementedError` to skip tests
Due to the issues fixed in the previous commits, these problems weren't caught by the test suite Fixes GSL integration with CPP/standalone Fixes #1686
Legend101Zz
reviewed
Sep 19, 2025
|
|
||
|
|
||
| class CodeObject(Nameable): | ||
| class CodeObject(Nameable, ABC): |
There was a problem hiding this comment.
yay ... now we use the ABC class :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GSL implementation did not catch up with recent changes in C++ standalone mode, leading it to raise
NotImplementedError. Unfortunately, the GSL test suite skips tests that raiseNotImplementedError, since this is supposed to be a signal for use of thenumpybackend, which doesn't have GSL support (this is probably not a good approach…). The failure therefore went unnoticed. A few small additional fixes were necessary, probably related to changes in our compiler flags.