Skip to content

Conversation

jammar1
Copy link
Contributor

@jammar1 jammar1 commented Sep 1, 2025

Hi,

I'm not sure this is the correct way to solve this crash.

When I upgraded to Wamr 2.4.1, I found that it was now crashing when calling wasm_store_delete with:
module error for object 0x120440078: pointer being freed was not allocated.

I think #3983 causes this issue, because module->is_binary_freeable is always set to false in create_module here: https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/aot/aot_loader.c#L4206 - even when clone_wasm_binary is set to false in the load args.

We don't set it for the module until here https://github.com/bytecodealliance/wasm-micro-runtime/blob/main/core/iwasm/common/wasm_runtime_common.c#L1492 after aot_load_from_aot_file has returned so it cannot be correct when we use it in the loader.

Thanks

@loganek
Copy link
Collaborator

loganek commented Sep 2, 2025

Do you happen to have a minimal reproducible example? I wonder why was that not captured in our tests.

@lum1n0us
Copy link
Collaborator

@jammar1 Would you mind sharing the steps to reproduce the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants