Skip to content

Refactor the CMake and related scripts for unit tests #4605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Refactor the CMake and related scripts for unit tests #4605

wants to merge 10 commits into from

Conversation

lum1n0us
Copy link
Collaborator

@lum1n0us lum1n0us commented Sep 8, 2025 •
edited
Loading

  • Improve the installation of 32-bit dependencies
  • output when unit test cases failed
  • Although the code coverage script works well on Ubuntu 22.04 (gcc11), it encountered several issues(bypassing by --ignore-errors) on Ubuntu 24.04 (gcc13). Add a warning to notice that.
  • Perform some refactoring to address these issues and create a lightweight template.
    • Only unit/CMakeLists.txt fetches googletest.
    • Find LLVM from the case on demand. unit_common.cmake prepares the LLVM_DIR in case config_common.cmake only does it when JIT is enabled.
    • Use WAMR_RUNTIME_LIB_SOURCE to replace a long list.
    • No global compilation flags in unit; each case identifies compilation flags for its unique test plan.
    • Standardize wasm-app compilation scripts. Use ExternalProject and the wasi-sdk toolchain file.
  • In test_warm.sh, run the unit test once instead of multiple times with different running modes, which is actually unnecessary.
  • Remove an incorrect mock from wasm_runtime_common_test.cc.

@lum1n0us lum1n0us force-pushed the fix/unit_coverage branch 3 times, most recently from 808a5d3 to 180b642 Compare September 8, 2025 23:36
@lum1n0us lum1n0us changed the title streamline CMake configurations and improve code coverage collection streamline CMake configurations Sep 9, 2025
@lum1n0us lum1n0us force-pushed the fix/unit_coverage branch 3 times, most recently from 02d19d7 to dd3bf40 Compare September 10, 2025 04:58
@lum1n0us lum1n0us mentioned this pull request Sep 14, 2025
Open
@lum1n0us lum1n0us changed the title streamline CMake configurations streamline CMake configurations in unit tests Sep 21, 2025
@lum1n0us lum1n0us changed the title streamline CMake configurations in unit tests Refactor the CMake and related scripts for unit tests Sep 24, 2025
@lum1n0us lum1n0us marked this pull request as ready for review September 25, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@TianlongLiang TianlongLiang Awaiting requested review from TianlongLiang TianlongLiang is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lum1n0us