Skip to content

Implement invokeNative asm code for armasm64 assembler on ARM64 Windows #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement invokeNative asm code for armasm64 assembler on ARM64 Windows #4636

wants to merge 2 commits into from

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Sep 16, 2025 •
edited
Loading

In ARM64 Windows, we need to use armasm64.exe instead of ml.exe.
So, we need to specify it manually inside of cmake files.

Fixes #4609.

@cosmo0920 cosmo0920 force-pushed the add-arm64-windows-assemblies branch from 8c0b5a0 to adbb644 Compare September 16, 2025 09:14
TianlongLiang
TianlongLiang approved these changes Sep 23, 2025
View reviewed changes
Copy link
Collaborator

@TianlongLiang TianlongLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, would you mind rebase after #4633?

@cosmo0920
Copy link
Contributor Author

Code LGTM, would you mind rebase after #4633?

Sure thing. Today is a public holiday here. So, I'll process tomorrow.

@cosmo0920 cosmo0920 force-pushed the add-arm64-windows-assemblies branch from adbb644 to f27b2c0 Compare September 24, 2025 02:36
@cosmo0920
Copy link
Contributor Author

I rebased off the current main. So, CI tasks are all succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TianlongLiang TianlongLiang TianlongLiang approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@lum1n0us lum1n0us Awaiting requested review from lum1n0us lum1n0us is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WAMR does not have ARM64 Windows assembly for native invokes
2 participants
@cosmo0920 @TianlongLiang